Skip to content

fix(issue-162): refactor(test): extract shared generateInvite helper in SettingsScreen tests - #171

Open
luandro wants to merge 2 commits into
mainfrom
agent/comapeo-cloud-app/issue-162
Open

fix(issue-162): refactor(test): extract shared generateInvite helper in SettingsScreen tests#171
luandro wants to merge 2 commits into
mainfrom
agent/comapeo-cloud-app/issue-162

Conversation

@luandro

@luandro luandro commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Changes

Implements #162 via autonomous Pool pipeline.

Verification

  • tsc --noEmit, vitest (unit), eslint src/ gate passed
  • Review: PASSED

Closes #162

@luandro
luandro marked this pull request as ready for review July 30, 2026 02:57
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Preview deployment ready: https://agent-comapeo-cloud-app-issu-1jme.comapeo-cloud-app.pages.dev

Commit: 22bed9b

@luandro luandro added agent:pr-readiness-in-progress PR lifecycle label agent:pr-needs-human PR needs human decision labels Jul 30, 2026
The preview smoke test failed with "Expected 400 ... got 404" because it
probed /api/info once, ~8s after "Deployment complete". Cloudflare Pages
Functions take a few seconds to propagate; until they are live, /api/*
falls through to the static 404 handler. A live probe minutes later returns
the correct 400.

Replace the single-shot probe with a poll that retries until the function
answers 400, while still asserting the final status is exactly 400 (no
suppression). Applied to the identical preview/staging/prod blocks; bumped
those smoke jobs to a 5m timeout to absorb the worst-case poll.

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:pr-needs-human PR needs human decision agent:pr-readiness-in-progress PR lifecycle label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(test): extract shared generateInvite helper in SettingsScreen tests

1 participant